Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js buffer constructor runtime deprecation #50

Closed
benjamingr opened this issue Mar 20, 2018 · 2 comments
Closed

Node.js buffer constructor runtime deprecation #50

benjamingr opened this issue Mar 20, 2018 · 2 comments

Comments

@benjamingr
Copy link

Hey @rvagg this repo was tagged in nodejs/node#19079 (comment) but I don't see any new Buffer usage here.

You're probably aware of the v10 change anyway - just making sure this doesn't get missed.
@ChALkeR
Copy link

ChALkeR commented Mar 20, 2018

https://github.com/rvagg/bl/blob/master/bl.js#L69
https://github.com/rvagg/bl/blob/master/bl.js#L130-L132
https://github.com/rvagg/bl/blob/master/bl.js#L167-L168

@benjamingr
Copy link
Author

@ChALkeR weird, GitHub code search didn't find it, should have probably used your code search tool :)

@mcollina mcollina mentioned this issue Mar 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChALkeR @benjamingr