Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writable stream API partially missing #50

Closed
dcousens opened this issue Jun 6, 2015 · 2 comments
Closed

Writable stream API partially missing #50

dcousens opened this issue Jun 6, 2015 · 2 comments

Comments

@dcousens
Copy link

dcousens commented Jun 6, 2015

The following methods (from the stream.Writable interface) are not exposed on a through2 stream:

Given that through2 is just a wrapper around a Transform; and a Transform is just a Duplex stream. And a Duplex stream is a:

... stream that implement[s] both the Readable and Writable interfaces.

What am I missing?

@dcousens dcousens changed the title Writable stream API missing Writable stream API partially missing Jun 6, 2015
@mafintosh
Copy link
Collaborator

through2 currently uses streams2 using the readable-stream module. the apis you are describing were added in streams3. i have an pr open for upgrading to streams3 (#46)

@dcousens
Copy link
Author

dcousens commented Jun 6, 2015

@mafintosh right! For some reason I thought the node docs were showing the streams 2 API. It'd be nice if the only version-like number they had on that page wasn't a 2.

Thanks @mafintosh.

@dcousens dcousens closed this as completed Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants