Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial support for string.format formatting #31

Closed
maxlapshin opened this issue Aug 19, 2013 · 6 comments
Closed

Partial support for string.format formatting #31

maxlapshin opened this issue Aug 19, 2013 · 6 comments

Comments

@maxlapshin
Copy link
Contributor

maxlapshin@be3135d

@rvirding
Copy link
Owner

Yes, about time to improve string.format. Do you have any priorities?

@maxlapshin
Copy link
Contributor Author

No, I don't have any priorities.

I just tried to implement a small part, required for me.

Robert, I really think that some unit tests are required. Unit or common test, what do you like more.

@rvirding
Copy link
Owner

OK, I will work on it.

Yes, we definitely need tests. I prefer common test, but if you want to use eunit it doesn't bother me. They can always be run from common test. :-)

@maxlapshin
Copy link
Contributor Author

I also like common test, it is easier to write and has cool html output.

If you will bootstrap some ct environment in develop branch, I'll try to make some pull requests for it.

@rvirding
Copy link
Owner

I have improved formatting in string.format. It is in the develop branch.

It can now handle the conversion specifiers q, s, c, i, d, o, x, e, f, g, %, the field width and precision and the flags 0, -, , +. It cannot yet handle multiple flags and does a poor job with the 0 flag and negative numbers.

@rvirding
Copy link
Owner

I have now fixed formatting in string.format so that it behaves properly. I will add documentation real soon now. It is in the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants