Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 commits, 4 comments:
We can still re-add the code later when working on SA. I think this was added for SA by accident anyway?
This also made it necessary to change some damage handler.
(No idea what the 80 means btw, I think there should be an enum for these values..)
(Unused at this point)
blendEnabled
bool is never actually set (which always forces enabledGL_BLEND
). However, setting it breaks the renderer because the blend state is not recovered on Renderer invalidation and even when adding that it's still broken because not everything invalidates the renderer..I didn't want to fix it as part of this commit so I only added a note and made the current operation more obvious (which also should cause a warning during compilation).
This avoids the shadow-z-fighting which is commonly seen under the train tracks.
I've also disabled depth writing for the text renderer but did not test if the actual game does that too.
I might have a look at text rendering soon anyway and it's easy enough to change it back if it's wrong.