make the health indicator blink if low

[snshn]

There's no game->getSecond(), so currently made it disappear once every two game-minutes, even though the vanilla engine makes it blink exactly twice in a single game-minute.
The time runs slightly faster in the original game than so I thought it's okay for now.

[JayFoxRox]

I'd suggest introducing a new variable in void IngameState::tick(float dt) to at least get the right behaviour.

Ideally we'll replace all of that with better code in the future? (I don't really like the autolook timer or my money hack either)

//Edit: Also please don't upate submodules unless necessary

[danhedron]

There's a floating point game timer GameState::gameTime, that will give sub-second accuracy.

[snshn]

Taken care of accidentally including the submodules in the commit.

The ::tick(float dt) way of doing it is probably more correct, but might be a bit too complex for my current level of understanding of the codebase.

Seems like using gameTime here worked quite well. It blinks with a pretty similar frequency to the original engine.

I agree with JayFoxRox and think that the code I'm committing here will eventually be replaced with the introduction of librw or just during one of code refactors in the future. I'm not too proud of this commit, but still feel like it's worth including just to make the UI behavior more complete at this stage.

[danhedron]

If blinking twice is the correct behaviour (it looks like it is) could you make this blink twice per in-game minute. That way we can have the correct behaviour in place when comparing behaviour before & after if this code gets refactored.

Besides that, looks good to me.

[snshn]

Sure. Could you please hint me at what the multiplier for gameMinute is, relative to gameTime?
I'm currently using 6.0 (42dbdb7#diff-dc88e3c6f116fe7ce03ca1b2e3bf3668R107) but it's likely not half of an in-game minute.

[JayFoxRox]

@vflyson I'm assuming the health blink is not tied to the game clock (gameMinute) but instead to a global timer (gameTime) (which may or may not pause in certain situations [pause menu etc.]). Did you try running the original game with cheats (do those exist) to advance the clock faster or something?

I'm not sure how fast any of these timers advance (but assume frames or seconds), so we still need @danhedron or you'll have to figure this out yourself :)

[snshn]

@JayFoxRox I've used adrenaline today (which on my 20th anniversary version freezes the in-game time completely) and the health indicator continued to blink with exactly the same frequency. It is most likely tied to the computer's clock in vanilla, not to in-game seconds of sorts.

Found a video on youtube where the health is low. The health indicator goes off 2 times and on 2 times as well in a single in-game minute, which makes it 1/4 of a game minute. I've updated the multiplier here, should be good to go.

[JayFoxRox]

how about fmod?
I'm totally against float pointers in general because they easily become inprecise due to float precision.
However, while we have them it looks like an even worse idea to convert them to integer.

//Edit: Also a comment what this math does wouldn't hurt (like: // UI: Blinking health indicator if health is low)

[snshn]

Thanks for the tip!

[danhedron]

LGTM