Add clang-tidy support #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far remember, we should be careful with auto. To made bit_cast simpler I used implicit conversion. |
ghost
reviewed
Apr 13, 2018
cmake_configure.cmake
Outdated
| endif() | ||
| set(CLANGTIDY_ARGS "${CLANGTIDY_PROGRAM}") | ||
| list(APPEND CLANGTIDY_ARGS | ||
| "-style=file" |
There was a problem hiding this comment.
The docs on http://clang.llvm.org/extra/clang-tidy/ show a -format-style=file option.
The version installed by fedora 26 does not have that option (version 4.0.1).
This maybe requires a FindClangTidy.cmake module if this option has changed.
There was a problem hiding this comment.
On arch I have to use "-format-style=file".
There was a problem hiding this comment.
I believe to have fixed it.
madebr
force-pushed
the
clangtidy
branch
2 times, most recently
from
893d7ce
to
5c8e978
Compare
ghost
approved these changes
May 31, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the clang-tidy linter to openrw.
All clang-tidy checks are enabled by default.
See http://clang.llvm.org/extra/clang-tidy/
Enabling clang-tidy autofix might result in incorrect source code, so manual checking is required.