Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Use find_package config mode for GLM #43

Merged
merged 1 commit into from
May 22, 2016

Conversation

ljrk0
Copy link
Contributor

@ljrk0 ljrk0 commented May 21, 2016

@ljrk0
Copy link
Contributor Author

ljrk0 commented May 21, 2016

[REVERTED]
I've also added Config mode for Bullet, since it does support it too.

@ljrk0
Copy link
Contributor Author

ljrk0 commented May 21, 2016

We could also remove cmake/modules/FindSFML.cmake as it is already provided by upstream:
https://github.com/SFML/SFML/blob/master/CMakeLists.txt#L297

@ljrk0
Copy link
Contributor Author

ljrk0 commented May 21, 2016

Just noticed that Bullet, although providing a Config cmake seems not to build properly that way. I'll investigate.

@ljrk0
Copy link
Contributor Author

ljrk0 commented May 21, 2016

Okay, deleted the commit. FindBullet.cmake is already provided by CMake itself, so we gonna use that. The Config way it doesn't set up include paths properly.

[Bulding completes now]

@Hockenberry
Copy link

Using patch (fe0c93f) under ubuntu 16.04 LTS does work with a glm rebuild from source.

@danhedron
Copy link
Member

Thanks.

@danhedron danhedron merged commit 680accc into rwengine:master May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants