Rename rwlib library to "core" to fit its new role #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would remove the |
madebr
suggested changes
Aug 8, 2018
core/CMakeLists.txt
Outdated
| @@ -65,15 +58,15 @@ target_link_libraries(rwlib | |||
| OpenGL::GL | |||
| ) | |||
|
|
|||
| set_target_properties(rwlib | |||
| set_target_properties(core | |||
| PROPERTIES | |||
| OUTPUT_NAME rw | |||
There was a problem hiding this comment.
These lines can be removed. The output name libcore (or librwcore) is fine. (Where librwlib was weird)
madebr
reviewed
Aug 8, 2018
CMakeLists.txt
Outdated
| @@ -66,7 +66,7 @@ endif() | |||
| # Create a rw_interface TARGET that holds all compiler options | |||
| include("${PROJECT_SOURCE_DIR}/cmake_configure.cmake") | |||
|
|
|||
| add_subdirectory(rwlib) | |||
| add_subdirectory(core) | |||
There was a problem hiding this comment.
Only remark(s) is to change this to rwcore too. Otherwise LGTM.
Also move up source files into the root directory, as there's nothing else in this directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we consider
librw, we need to move our rwlib out of the way to avoid confusion.This changes our library to be called
core, as it will remain to house low level utilities and OS abstractions that OpenRW is still using.Future work will look at which pieces of this library are likely to become redundant and can be removed.