Pause all other sounds during a cutscene #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contribution. ^^ I'll review and test it tomorrow. |
ghost
reviewed
Oct 23, 2018
rwengine/src/engine/GameWorld.cpp
Outdated
| @@ -881,7 +883,11 @@ void GameWorld::clearTickData() { | |||
|
|
|||
| void GameWorld::setPaused(bool pause) { | |||
| paused = pause; | |||
| sound.pause(pause); | |||
| if (!pause && !isCutsceneDone()) { | |||
There was a problem hiding this comment.
It's hard to understand the purpose of this condition, I'd extract and name it. (For example resumingCutscene)
|
Thanks. Tested, works fine. Todo: later verify if original also stops sfx generated by 018d and background. (Don't have windows to check. :( ) |
ghost
approved these changes
Oct 25, 2018
dracc
reviewed
Oct 25, 2018
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #583
I tested only the cutscene on the first mission (Luigi's Girls), but it should work for any other.