Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix LUIGI3 (Drive Misty For Me) #99

Merged
merged 7 commits into from
May 30, 2016

Conversation

JayFoxRox
Copy link
Collaborator

This adds the missing functionality for LUIGI3 + tiny printf bugfix.

There are still some known issues:

  • The doors to Mistys house do not open properly when loaded from savegame (even with Create object instances from savegame #98 )
    I did not test wether this works when the objects are created from the Script. It's very possible that the game currently rotates some random object, thinking that it is the door to Mistys place.
  • Once Misty is in the car you can't leave it. Leaving the car will ASSERT and SIGSEGV here (not 100% sure it was this line, better confirm seperately!)
  • Once the mission has passed (= after "Mission Passed" text) the camera didn't reset and I didn't get control back
  • Doors are broken in mission start and end cutscenes ( Doors at Luigis place don't open #51 )

Fixes some things in #52 .


I can rename / squash the commits if you want, I wasn't sure about your naming conventions.
There were some whitespace errors (empty lines with spaces) in the code which I copied for some of my functions.
I'll force push these away later in my code (unless you are fine with them) but I want to get feedback first so I can address other issues at the same time.

@danhedron danhedron merged commit 42ef849 into rwengine:master May 30, 2016
@JayFoxRox JayFoxRox deleted the fix-luigi3 branch June 24, 2016 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants