Don't hardcode screenshot directory (still hardcodes filename) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Crittenden <rcrit@greyoak.com>
|
Thanks! It would be nice if this were cross platform, but there are a few other places where unix is assumed so this can be cleaned up along with them later. |
madebr
added a commit
to madebr/openrw
that referenced
this pull request
Sep 5, 2017
- rename each test to test_Xxx (with capital)
- ctest also generates a nice output
New output:
$ make test
Running tests...
Test project /home/maarten/programming/openrw/build
Start 1: Animation
1/33 Test #1: Animation ........................ Passed 0.73 sec
Start 2: Archive
2/33 Test #2: Archive .......................... Passed 0.01 sec
Start 3: Buoyancy
3/33 Test #3: Buoyancy ......................... Passed 0.74 sec
Start 4: Character
4/33 Test #4: Character ........................***Failed 0.82 sec
Start 5: Chase
5/33 Test #5: Chase ............................ Passed 0.01 sec
Start 6: Cutscene
6/33 Test rwengine#6: Cutscene ......................... Passed 0.70 sec
Start 7: Config
7/33 Test rwengine#7: Config ........................... Passed 0.01 sec
Start 8: Data
8/33 Test rwengine#8: Data ............................. Passed 0.75 sec
Start 9: FileIndex
9/33 Test rwengine#9: FileIndex ........................ Passed 0.01 sec
Start 10: GameData
10/33 Test rwengine#10: GameData ......................... Passed 3.70 sec
Start 11: GameWorld
11/33 Test rwengine#11: GameWorld ........................ Passed 0.72 sec
Start 12: Item
12/33 Test rwengine#12: Item ............................. Passed 0.72 sec
Start 13: Input
13/33 Test rwengine#13: Input ............................ Passed 0.01 sec
Start 14: Lifetime
14/33 Test rwengine#14: Lifetime ......................... Passed 0.70 sec
Start 15: LoaderDFF
15/33 Test rwengine#15: LoaderDFF ........................ Passed 0.73 sec
Start 16: LoaderIPL
16/33 Test rwengine#16: LoaderIPL ........................ Passed 0.71 sec
Start 17: Logger
17/33 Test rwengine#17: Logger ........................... Passed 0.01 sec
Start 18: Menu
18/33 Test rwengine#18: Menu ............................. Passed 0.01 sec
Start 19: Object
19/33 Test rwengine#19: Object ...........................***Failed 0.01 sec
Start 20: ObjectData
20/33 Test rwengine#20: ObjectData ....................... Passed 0.71 sec
Start 21: Pickup
21/33 Test rwengine#21: Pickup ...........................***Failed 0.71 sec
Start 22: Renderer
22/33 Test rwengine#22: Renderer ......................... Passed 0.01 sec
Start 23: RWBStream
23/33 Test rwengine#23: RWBStream ........................ Passed 0.71 sec
Start 24: SaveGame
24/33 Test rwengine#24: SaveGame .........................***Failed 0.01 sec
Start 25: ScriptMachine
25/33 Test rwengine#25: ScriptMachine .................... Passed 0.01 sec
Start 26: State
26/33 Test rwengine#26: State ............................***Failed 0.01 sec
Start 27: Text
27/33 Test rwengine#27: Text ............................. Passed 0.70 sec
Start 28: TrafficDirector
28/33 Test rwengine#28: TrafficDirector .................. Passed 0.77 sec
Start 29: Vehicle
29/33 Test rwengine#29: Vehicle .......................... Passed 0.70 sec
Start 30: VisualFX
30/33 Test rwengine#30: VisualFX ......................... Passed 0.01 sec
Start 31: Weapon
31/33 Test rwengine#31: Weapon ........................... Passed 0.72 sec
Start 32: World
32/33 Test rwengine#32: World ............................ Passed 0.01 sec
Start 33: ZoneData
33/33 Test rwengine#33: ZoneData ......................... Passed 0.01 sec
85% tests passed, 5 tests failed out of 33
Total Test time (real) = 16.18 sec
The following tests FAILED:
4 - Character (Failed)
19 - Object (Failed)
21 - Pickup (Failed)
24 - SaveGame (Failed)
26 - State (Failed)
Errors while running CTest
make: *** [Makefile:95: test] Error 8
madebr
added a commit
to madebr/openrw
that referenced
this pull request
Sep 5, 2017
- rename each test to test_Xxx (with capital)
- ctest also generates a nice output
New output:
$ make test
Running tests...
Test project /home/maarten/programming/openrw/build
Start 1: Animation
1/33 Test #1: Animation ........................ Passed 0.73 sec
Start 2: Archive
2/33 Test #2: Archive .......................... Passed 0.01 sec
Start 3: Buoyancy
3/33 Test #3: Buoyancy ......................... Passed 0.74 sec
Start 4: Character
4/33 Test #4: Character ........................***Failed 0.82 sec
Start 5: Chase
5/33 Test #5: Chase ............................ Passed 0.01 sec
Start 6: Cutscene
6/33 Test rwengine#6: Cutscene ......................... Passed 0.70 sec
Start 7: Config
7/33 Test rwengine#7: Config ........................... Passed 0.01 sec
Start 8: Data
8/33 Test rwengine#8: Data ............................. Passed 0.75 sec
Start 9: FileIndex
9/33 Test rwengine#9: FileIndex ........................ Passed 0.01 sec
Start 10: GameData
10/33 Test rwengine#10: GameData ......................... Passed 3.70 sec
Start 11: GameWorld
11/33 Test rwengine#11: GameWorld ........................ Passed 0.72 sec
Start 12: Item
12/33 Test rwengine#12: Item ............................. Passed 0.72 sec
Start 13: Input
13/33 Test rwengine#13: Input ............................ Passed 0.01 sec
Start 14: Lifetime
14/33 Test rwengine#14: Lifetime ......................... Passed 0.70 sec
Start 15: LoaderDFF
15/33 Test rwengine#15: LoaderDFF ........................ Passed 0.73 sec
Start 16: LoaderIPL
16/33 Test rwengine#16: LoaderIPL ........................ Passed 0.71 sec
Start 17: Logger
17/33 Test rwengine#17: Logger ........................... Passed 0.01 sec
Start 18: Menu
18/33 Test rwengine#18: Menu ............................. Passed 0.01 sec
Start 19: Object
19/33 Test rwengine#19: Object ...........................***Failed 0.01 sec
Start 20: ObjectData
20/33 Test rwengine#20: ObjectData ....................... Passed 0.71 sec
Start 21: Pickup
21/33 Test rwengine#21: Pickup ...........................***Failed 0.71 sec
Start 22: Renderer
22/33 Test rwengine#22: Renderer ......................... Passed 0.01 sec
Start 23: RWBStream
23/33 Test rwengine#23: RWBStream ........................ Passed 0.71 sec
Start 24: SaveGame
24/33 Test rwengine#24: SaveGame .........................***Failed 0.01 sec
Start 25: ScriptMachine
25/33 Test rwengine#25: ScriptMachine .................... Passed 0.01 sec
Start 26: State
26/33 Test rwengine#26: State ............................***Failed 0.01 sec
Start 27: Text
27/33 Test rwengine#27: Text ............................. Passed 0.70 sec
Start 28: TrafficDirector
28/33 Test rwengine#28: TrafficDirector .................. Passed 0.77 sec
Start 29: Vehicle
29/33 Test rwengine#29: Vehicle .......................... Passed 0.70 sec
Start 30: VisualFX
30/33 Test rwengine#30: VisualFX ......................... Passed 0.01 sec
Start 31: Weapon
31/33 Test rwengine#31: Weapon ........................... Passed 0.72 sec
Start 32: World
32/33 Test rwengine#32: World ............................ Passed 0.01 sec
Start 33: ZoneData
33/33 Test rwengine#33: ZoneData ......................... Passed 0.01 sec
85% tests passed, 5 tests failed out of 33
Total Test time (real) = 16.18 sec
The following tests FAILED:
4 - Character (Failed)
19 - Object (Failed)
21 - Pickup (Failed)
24 - SaveGame (Failed)
26 - State (Failed)
Errors while running CTest
make: *** [Makefile:95: test] Error 8
madebr
added a commit
to madebr/openrw
that referenced
this pull request
Sep 7, 2017
- rename each test to test_Xxx (with capital)
- ctest also generates a nice output
New output:
$ make test
Running tests...
Test project /home/maarten/programming/openrw/build
Start 1: Animation
1/33 Test #1: Animation ........................ Passed 0.73 sec
Start 2: Archive
2/33 Test #2: Archive .......................... Passed 0.01 sec
Start 3: Buoyancy
3/33 Test #3: Buoyancy ......................... Passed 0.74 sec
Start 4: Character
4/33 Test #4: Character ........................***Failed 0.82 sec
Start 5: Chase
5/33 Test #5: Chase ............................ Passed 0.01 sec
Start 6: Cutscene
6/33 Test rwengine#6: Cutscene ......................... Passed 0.70 sec
Start 7: Config
7/33 Test rwengine#7: Config ........................... Passed 0.01 sec
Start 8: Data
8/33 Test rwengine#8: Data ............................. Passed 0.75 sec
Start 9: FileIndex
9/33 Test rwengine#9: FileIndex ........................ Passed 0.01 sec
Start 10: GameData
10/33 Test rwengine#10: GameData ......................... Passed 3.70 sec
Start 11: GameWorld
11/33 Test rwengine#11: GameWorld ........................ Passed 0.72 sec
Start 12: Item
12/33 Test rwengine#12: Item ............................. Passed 0.72 sec
Start 13: Input
13/33 Test rwengine#13: Input ............................ Passed 0.01 sec
Start 14: Lifetime
14/33 Test rwengine#14: Lifetime ......................... Passed 0.70 sec
Start 15: LoaderDFF
15/33 Test rwengine#15: LoaderDFF ........................ Passed 0.73 sec
Start 16: LoaderIPL
16/33 Test rwengine#16: LoaderIPL ........................ Passed 0.71 sec
Start 17: Logger
17/33 Test rwengine#17: Logger ........................... Passed 0.01 sec
Start 18: Menu
18/33 Test rwengine#18: Menu ............................. Passed 0.01 sec
Start 19: Object
19/33 Test rwengine#19: Object ...........................***Failed 0.01 sec
Start 20: ObjectData
20/33 Test rwengine#20: ObjectData ....................... Passed 0.71 sec
Start 21: Pickup
21/33 Test rwengine#21: Pickup ...........................***Failed 0.71 sec
Start 22: Renderer
22/33 Test rwengine#22: Renderer ......................... Passed 0.01 sec
Start 23: RWBStream
23/33 Test rwengine#23: RWBStream ........................ Passed 0.71 sec
Start 24: SaveGame
24/33 Test rwengine#24: SaveGame .........................***Failed 0.01 sec
Start 25: ScriptMachine
25/33 Test rwengine#25: ScriptMachine .................... Passed 0.01 sec
Start 26: State
26/33 Test rwengine#26: State ............................***Failed 0.01 sec
Start 27: Text
27/33 Test rwengine#27: Text ............................. Passed 0.70 sec
Start 28: TrafficDirector
28/33 Test rwengine#28: TrafficDirector .................. Passed 0.77 sec
Start 29: Vehicle
29/33 Test rwengine#29: Vehicle .......................... Passed 0.70 sec
Start 30: VisualFX
30/33 Test rwengine#30: VisualFX ......................... Passed 0.01 sec
Start 31: Weapon
31/33 Test rwengine#31: Weapon ........................... Passed 0.72 sec
Start 32: World
32/33 Test rwengine#32: World ............................ Passed 0.01 sec
Start 33: ZoneData
33/33 Test rwengine#33: ZoneData ......................... Passed 0.01 sec
85% tests passed, 5 tests failed out of 33
Total Test time (real) = 16.18 sec
The following tests FAILED:
4 - Character (Failed)
19 - Object (Failed)
21 - Pickup (Failed)
24 - SaveGame (Failed)
26 - State (Failed)
Errors while running CTest
make: *** [Makefile:95: test] Error 8
madebr
added a commit
to madebr/openrw
that referenced
this pull request
Sep 7, 2017
- rename each test to test_Xxx (with capital)
- ctest also generates a nice output
New output:
$ make test
Running tests...
Test project /home/maarten/programming/openrw/build
Start 1: Animation
1/33 Test #1: Animation ........................ Passed 0.73 sec
Start 2: Archive
2/33 Test #2: Archive .......................... Passed 0.01 sec
Start 3: Buoyancy
3/33 Test #3: Buoyancy ......................... Passed 0.74 sec
Start 4: Character
4/33 Test #4: Character ........................***Failed 0.82 sec
Start 5: Chase
5/33 Test #5: Chase ............................ Passed 0.01 sec
Start 6: Cutscene
6/33 Test rwengine#6: Cutscene ......................... Passed 0.70 sec
Start 7: Config
7/33 Test rwengine#7: Config ........................... Passed 0.01 sec
Start 8: Data
8/33 Test rwengine#8: Data ............................. Passed 0.75 sec
Start 9: FileIndex
9/33 Test rwengine#9: FileIndex ........................ Passed 0.01 sec
Start 10: GameData
10/33 Test rwengine#10: GameData ......................... Passed 3.70 sec
Start 11: GameWorld
11/33 Test rwengine#11: GameWorld ........................ Passed 0.72 sec
Start 12: Item
12/33 Test rwengine#12: Item ............................. Passed 0.72 sec
Start 13: Input
13/33 Test rwengine#13: Input ............................ Passed 0.01 sec
Start 14: Lifetime
14/33 Test rwengine#14: Lifetime ......................... Passed 0.70 sec
Start 15: LoaderDFF
15/33 Test rwengine#15: LoaderDFF ........................ Passed 0.73 sec
Start 16: LoaderIPL
16/33 Test rwengine#16: LoaderIPL ........................ Passed 0.71 sec
Start 17: Logger
17/33 Test rwengine#17: Logger ........................... Passed 0.01 sec
Start 18: Menu
18/33 Test rwengine#18: Menu ............................. Passed 0.01 sec
Start 19: Object
19/33 Test rwengine#19: Object ...........................***Failed 0.01 sec
Start 20: ObjectData
20/33 Test rwengine#20: ObjectData ....................... Passed 0.71 sec
Start 21: Pickup
21/33 Test rwengine#21: Pickup ...........................***Failed 0.71 sec
Start 22: Renderer
22/33 Test rwengine#22: Renderer ......................... Passed 0.01 sec
Start 23: RWBStream
23/33 Test rwengine#23: RWBStream ........................ Passed 0.71 sec
Start 24: SaveGame
24/33 Test rwengine#24: SaveGame .........................***Failed 0.01 sec
Start 25: ScriptMachine
25/33 Test rwengine#25: ScriptMachine .................... Passed 0.01 sec
Start 26: State
26/33 Test rwengine#26: State ............................***Failed 0.01 sec
Start 27: Text
27/33 Test rwengine#27: Text ............................. Passed 0.70 sec
Start 28: TrafficDirector
28/33 Test rwengine#28: TrafficDirector .................. Passed 0.77 sec
Start 29: Vehicle
29/33 Test rwengine#29: Vehicle .......................... Passed 0.70 sec
Start 30: VisualFX
30/33 Test rwengine#30: VisualFX ......................... Passed 0.01 sec
Start 31: Weapon
31/33 Test rwengine#31: Weapon ........................... Passed 0.72 sec
Start 32: World
32/33 Test rwengine#32: World ............................ Passed 0.01 sec
Start 33: ZoneData
33/33 Test rwengine#33: ZoneData ......................... Passed 0.01 sec
85% tests passed, 5 tests failed out of 33
Total Test time (real) = 16.18 sec
The following tests FAILED:
4 - Character (Failed)
19 - Object (Failed)
21 - Pickup (Failed)
24 - SaveGame (Failed)
26 - State (Failed)
Errors while running CTest
make: *** [Makefile:95: test] Error 8
madebr
added a commit
to madebr/openrw
that referenced
this pull request
Sep 7, 2017
- rename each test to test_Xxx (with capital)
- ctest also generates a nice output
New output:
$ make test
Running tests...
Test project /home/maarten/programming/openrw/build
Start 1: Animation
1/33 Test #1: Animation ........................ Passed 0.73 sec
Start 2: Archive
2/33 Test #2: Archive .......................... Passed 0.01 sec
Start 3: Buoyancy
3/33 Test #3: Buoyancy ......................... Passed 0.74 sec
Start 4: Character
4/33 Test #4: Character ........................***Failed 0.82 sec
Start 5: Chase
5/33 Test #5: Chase ............................ Passed 0.01 sec
Start 6: Cutscene
6/33 Test rwengine#6: Cutscene ......................... Passed 0.70 sec
Start 7: Config
7/33 Test rwengine#7: Config ........................... Passed 0.01 sec
Start 8: Data
8/33 Test rwengine#8: Data ............................. Passed 0.75 sec
Start 9: FileIndex
9/33 Test rwengine#9: FileIndex ........................ Passed 0.01 sec
Start 10: GameData
10/33 Test rwengine#10: GameData ......................... Passed 3.70 sec
Start 11: GameWorld
11/33 Test rwengine#11: GameWorld ........................ Passed 0.72 sec
Start 12: Item
12/33 Test rwengine#12: Item ............................. Passed 0.72 sec
Start 13: Input
13/33 Test rwengine#13: Input ............................ Passed 0.01 sec
Start 14: Lifetime
14/33 Test rwengine#14: Lifetime ......................... Passed 0.70 sec
Start 15: LoaderDFF
15/33 Test rwengine#15: LoaderDFF ........................ Passed 0.73 sec
Start 16: LoaderIPL
16/33 Test rwengine#16: LoaderIPL ........................ Passed 0.71 sec
Start 17: Logger
17/33 Test rwengine#17: Logger ........................... Passed 0.01 sec
Start 18: Menu
18/33 Test rwengine#18: Menu ............................. Passed 0.01 sec
Start 19: Object
19/33 Test rwengine#19: Object ...........................***Failed 0.01 sec
Start 20: ObjectData
20/33 Test rwengine#20: ObjectData ....................... Passed 0.71 sec
Start 21: Pickup
21/33 Test rwengine#21: Pickup ...........................***Failed 0.71 sec
Start 22: Renderer
22/33 Test rwengine#22: Renderer ......................... Passed 0.01 sec
Start 23: RWBStream
23/33 Test rwengine#23: RWBStream ........................ Passed 0.71 sec
Start 24: SaveGame
24/33 Test rwengine#24: SaveGame .........................***Failed 0.01 sec
Start 25: ScriptMachine
25/33 Test rwengine#25: ScriptMachine .................... Passed 0.01 sec
Start 26: State
26/33 Test rwengine#26: State ............................***Failed 0.01 sec
Start 27: Text
27/33 Test rwengine#27: Text ............................. Passed 0.70 sec
Start 28: TrafficDirector
28/33 Test rwengine#28: TrafficDirector .................. Passed 0.77 sec
Start 29: Vehicle
29/33 Test rwengine#29: Vehicle .......................... Passed 0.70 sec
Start 30: VisualFX
30/33 Test rwengine#30: VisualFX ......................... Passed 0.01 sec
Start 31: Weapon
31/33 Test rwengine#31: Weapon ........................... Passed 0.72 sec
Start 32: World
32/33 Test rwengine#32: World ............................ Passed 0.01 sec
Start 33: ZoneData
33/33 Test rwengine#33: ZoneData ......................... Passed 0.01 sec
85% tests passed, 5 tests failed out of 33
Total Test time (real) = 16.18 sec
The following tests FAILED:
4 - Character (Failed)
19 - Object (Failed)
21 - Pickup (Failed)
24 - SaveGame (Failed)
26 - State (Failed)
Errors while running CTest
make: *** [Makefile:95: test] Error 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously it would be nice to generate a unique name for the screenshot but this at least removes the hardcoded directory.