Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the default launch message #2569

Closed
Stefanuk12 opened this issue Jun 30, 2023 · 1 comment
Closed

Changing the default launch message #2569

Stefanuk12 opened this issue Jun 30, 2023 · 1 comment
Labels
request Request for new functionality

Comments

@Stefanuk12
Copy link

The problem

You cannot change the launch message easily as it's hardcoded as seen here. You currently have to disable all logging in order to achieve this, but you might want to keep the rest of the logging, and only change the launch message.

A possible solution

An optional parameter could be passed within the launch function which is passed to the logging macro instead of the hardcoded default. An example usage could be like this:

rocket.launch("Server started")

This may break existing codebases so to minimise this, a function called launch_with_message could be used instead.

@SergioBenitez
Copy link
Member

I don't think we need any explicit APIs to support this. When we get to #21, we should make sure that removing this message is pretty trivial, however. Adding your own message is already trivial via a launch fairing.

@SergioBenitez SergioBenitez closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants