Skip to content
This repository has been archived by the owner on Jan 12, 2020. It is now read-only.

Old version of ember-decorators was causing problems #27

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 16, 2019

The old version was the cause of ember-cli/ember-octane-blueprint#37 (comment)

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 16, 2019 18:40
Copy link
Owner

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~Hmm, I would expect you to update the files in the blueprint not the top level package.json 🤔 ~~

Never mind! Got confused!

@rwjblue rwjblue merged commit 56be780 into rwjblue:master Feb 16, 2019
@NullVoxPopuli
Copy link
Contributor Author

I wasn't having a generating problem, it was a dev-assertion.

latest ember-source does an assertion on computed that they are of a certain type.
this version of sparkles-component ends up returning the wrong thing.

@NullVoxPopuli NullVoxPopuli deleted the upgrade-e-d branch February 16, 2019 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants