Add support for the yescrypt hash method. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Esser <besser82@fedoraproject.org>
The yescrypt hashing method is considered to be much stronger than sha512crypt and fully supported by libxcrypt >= 4.3. It is based on NIST-approved primitives, like PBKDF2, and on par with argon2 in strength. Fresh installed systems, as well as newly computed hashes for the UNIX shadow file should prefer this method, if the crypt() function, the distro ships, is capable of computing such hashes. Signed-off-by: Björn Esser <besser82@fedoraproject.org>
Add support for the new cli-parameter `yescrypt` for the `--password-crypto` switch to virt-alignment-scan, as we added support for this hashing method to the `customize/password.ml` file in the previous commit. Signed-off-by: Björn Esser <besser82@fedoraproject.org>
|
Thanks, I have pushed it. |
|
You're welcome! =) |
|
Do you plan to cut a new release within the next days, or shall I open a PR for the Fedora package, too? |
|
Sure I can do a release tomorrow. No need to file a bug. |
That would be great! Thank you! |
|
That's really cool! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yescrypt hashing method is considered to be much stronger than sha512crypt and fully supported by libxcrypt >= 4.3.
It is based on NIST-approved primitives, like PBKDF2, and on par with argon2 in strength.
Fresh installed systems, as well as newly computed hashes for the UNIX shadow file should prefer this method, if the crypt() function, the distro ships, is capable of computing such hashes.
See: https://fedoraproject.org/wiki/Changes/yescrypt_as_default_hashing_method_for_shadow