Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style guide to wiki #1

Closed
marcusfuchs opened this issue Jul 10, 2014 · 3 comments
Closed

Add style guide to wiki #1

marcusfuchs opened this issue Jul 10, 2014 · 3 comments

Comments

@marcusfuchs
Copy link

Add style guide to wiki for contributions

@psteinhoff
Copy link

I think this is a nice summary for a possible workflow for contributions.
https://guides.github.com/introduction/flow/index.html

Forking a repo, working on an issue (comitting changes in short periods, perhaps in an specific branch) and sending the pull-request to AixLib will possibly be the best choice.

@marcusfuchs
Copy link
Author

I think this is a good starting point for the discussion. As I understand it, the link @psteinhoff provided describes the concept of branching and reintroducing the changes into the master with a pull request. This seems like the best way to go. Yet, the question whether to open and work on the branch in RWTH-EBC/AixLib or in your own fork /AixLib is not addressed in the link and I think there are good arguments for both ways.

I slightly tend to suggest a standard flow of working on the branch in RWTH-EBC/AixLib. This would omit the additional steps of opening and keeping my own fork up to date. In addition, forking could be mentioned as a second option, as it does have advantages for larger individual development and there is no reason to refuse a pull request from such a fork.

@marcusfuchs
Copy link
Author

Added a workflow description closely following the Annex 60 workflow. We can add a detailed style guide with version 1.0.0 (or earlier if applicable).

PRemmen added a commit that referenced this issue Nov 5, 2020
PRemmen added a commit that referenced this issue Nov 5, 2020
Merge pull request #1 from RWTH-EBC/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants