Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ember-cli-dependency-checker is present #35

Closed
rwz opened this issue Dec 23, 2014 · 3 comments
Closed

Make sure ember-cli-dependency-checker is present #35

rwz opened this issue Dec 23, 2014 · 3 comments

Comments

@rwz
Copy link
Collaborator

rwz commented Dec 23, 2014

Without it there could be a situation when one developer runs npm install --save-dev ember-cli-rails-addon and commits changes to package.json, but then other developer pulls the change and runs rails without running npm install.

NPM doesn't actually perform any dependency checking before executing the code, so builds are running without the addon, and all sorts of weird shit happening. :(

@rwjblue
Copy link
Contributor

rwjblue commented Dec 23, 2014

ember-cli-rails-addon can throw or console.error if it is not present in package.json.

@rwz
Copy link
Collaborator Author

rwz commented Dec 23, 2014

The problem is the gem only checks package.json, but not the actual presence of stuff in node_modules. We had an issue when package.json check passed successfully and builds were happening, but the addon was not installed and loaded.

So, when addon is not running, adding checks to it won't solve the problem.

I think the other thing we could/should do is to make addon check smarter and actually make it go deeper into node-modules to eliminate these situations.

@rwjblue
Copy link
Contributor

rwjblue commented Dec 23, 2014

Submitted #36 and rondale-sc/ember-cli-rails-addon#4 to assist in this.

@rwz rwz closed this as completed in 5698c1d Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants