Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if ember-cli-dependency-checker is missing. #4

Merged

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Dec 23, 2014

rondale-sc added a commit that referenced this pull request Dec 23, 2014
Warn if ember-cli-dependency-checker is missing.
@rondale-sc rondale-sc merged commit c7aaf8b into rondale-sc:master Dec 23, 2014
@rondale-sc
Copy link
Owner

This has the desired affect when you run ember build (and similar ember-cli commands) but we aren't doing anything with the output from the system (or spawn) call in ember-cli-rails so this error message doesn't show up there.

We likely need to trap the string returned from system and show errors manually (or some similar mechanism).

/cc @rwz rwjblue tricknotes/ember-cli-rails#35

@rwjblue
Copy link
Collaborator Author

rwjblue commented Dec 23, 2014

@rondale-sc - Great point. Perhaps we could change this to write to stderr (via console.error), and in ember-cli-rails we pass through stderr?

@rwjblue rwjblue deleted the warn-on-missing-dependency-checker branch December 23, 2014 13:50
@rondale-sc
Copy link
Owner

I'm not sure the mechanism. I believe stdout and stderr are shared with the parent process in spawn but ignored in system. We'll see what @rwz thinks. Either way, this is out.

https://www.npmjs.com/package/ember-cli-rails-addon

Bumped to 0.0.6 :)

Thanks for the PR 🎅

[edit] I'll try to check this in development, but it'll have to wait until later...travellin' and stuff

@rondale-sc
Copy link
Owner

Seems as if we are intentionally silencing the output from the system call here.

If you remove silence_stream the output from ember commands comes through in test, however, we lose all formatting which makes it looks a little cluttered. I don't think we can preserve the formatting, but maybe we can do something with that information.

Right now we get something that looks like this:

You can see the "Building..." stuff is just butted right up with the warning (which I was testing in this example).

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants