Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix showing the required ember-cli npm version #47

Merged
merged 1 commit into from
Jan 6, 2015

Conversation

jhsu
Copy link
Contributor

@jhsu jhsu commented Jan 6, 2015

with the incorrect version installed, an undefined error is thrown:

NameError (undefined local variable or method `requirement' for #<EmberCLI::App:0x007feaf89b0df8>):
  ember-cli-rails (0.0.14) lib/ember-cli/app.rb:111:in `check_ember_cli_version!'
  ...

rwz added a commit that referenced this pull request Jan 6, 2015
fix showing the required ember-cli npm version
@rwz rwz merged commit 1cfa00c into tricknotes:master Jan 6, 2015
@rwz
Copy link
Collaborator

rwz commented Jan 6, 2015

Man, we really need to write some test for that :(

Thanks for the fix!

@rwz
Copy link
Collaborator

rwz commented Jan 6, 2015

Released 0.0.15

@rondale-sc
Copy link
Collaborator

@rwz Yeah, totally. Some simple tests might be good, but I'm not sure how we'd setup a test harnes that'd cover all the versions of ember-cli and Rails that we support. :( If you have any ideas, I'd really like some coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants