Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor Overload #11

Closed
RxDave opened this issue May 28, 2016 · 3 comments
Closed

Visitor Overload #11

RxDave opened this issue May 28, 2016 · 3 comments

Comments

@RxDave
Copy link
Owner

RxDave commented May 28, 2016

Consider defining an overload of the service operators (and secure variants) accepting an expression tree visitor rather than an IQbservableProvider. This could make pre-processing much easier for services since in many cases the only reason for creating their own providers, which can be failry complex, is to have access to a single visitor. Also consider an overload that takes a sequence of visitors and applies them to the client's expression in the order in which they're specified.

RxDave added a commit that referenced this issue Jun 22, 2016
…ptions instance that you pass to the service operators/factories.
@RxDave
Copy link
Owner Author

RxDave commented Jun 22, 2016

To be released in the version following 2.0.4.

@RxDave RxDave closed this as completed Jun 22, 2016
@RxDave
Copy link
Owner Author

RxDave commented Mar 18, 2017

Reopening because the visitor needs to be a factory so that the visitor object itself can be stateful. As of the current implementation, the supplied visitor referenced is shared by every subscriber.

@RxDave RxDave reopened this Mar 18, 2017
RxDave added a commit that referenced this issue Aug 23, 2017
@RxDave
Copy link
Owner Author

RxDave commented Aug 23, 2017

Fixed for the next release.

@RxDave RxDave closed this as completed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant