Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🌐 Add 🇺🇦 Ukrainian translation #1095

Merged
merged 1 commit into from
Mar 4, 2023
Merged

feat: 🌐 Add 🇺🇦 Ukrainian translation #1095

merged 1 commit into from
Mar 4, 2023

Conversation

kopach
Copy link
Contributor

@kopach kopach commented Mar 3, 2023 •
edited
Loading

Ref: #1094

rxhanson
rxhanson requested changes Mar 4, 2023
View reviewed changes
Copy link
Owner

@rxhanson rxhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one missing one near the end.

@kopach
Copy link
Contributor Author

kopach commented Mar 4, 2023

Thanks! Just one missing one near the end.

fixed @rxhanson. Please, take a look once again, thanks

Btw, how about this file https://github.com/rxhanson/Rectangle/blob/aa434500ec61292c5bf7da92c8fb0de477abdf54/RectangleLauncher/uk.lproj/Main.strings
Should it also be translated?

@rxhanson
Copy link
Owner

rxhanson commented Mar 4, 2023

Thanks! That file doesn't need to be translated (it's the embedded helper app without a UI that is used to launch the app on startup for macOS < 13).

@rxhanson rxhanson merged commit 10be701 into rxhanson:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxhanson rxhanson rxhanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kopach @rxhanson