Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expectation not supporting all traits #32

Closed
NeverwinterMoon opened this issue Aug 19, 2018 · 1 comment · Fixed by #44
Closed

Expectation not supporting all traits #32

NeverwinterMoon opened this issue Aug 19, 2018 · 1 comment · Fixed by #44
Assignees
@M0rtyMerr
Labels
help wanted

Comments

@NeverwinterMoon
Copy link
Member

I personally ran into a problem where Single was not supported. Single is widely used for HTTP requests as we expect just a single value/error, not a stream of multiple events.

Currently, expectation confronts to T : ObservableType, if it would be switched to T: ObservableConvertibleType, it would support all observables that have toBlocking support.
@M0rtyMerr
Copy link
Member

@NeverwinterMoon just met the same issue, going to open pr.

@M0rtyMerr M0rtyMerr self-assigned this May 25, 2019
@M0rtyMerr M0rtyMerr mentioned this issue May 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M0rtyMerr M0rtyMerr

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change ObservableType to ObservableConvertibleType RxSwiftCommunity/RxNimble
2 participants
@NeverwinterMoon @M0rtyMerr