This repository has been archived by the owner on Oct 19, 2019. It is now read-only.
Update for latest stable version of V8 (4.8) #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ outdir="`pwd`/v8/out/$target" | |||
| libv8_base="`find $outdir -name 'libv8_base.a' | head -1`" | |||
| libv8_libbase="`find $outdir -name 'libv8_libbase.a' | head -1`" | |||
| libv8_libplatform=`find $outdir -name 'libv8_libplatform.a' | head -1`"" | |||
| libv8_snapshot=`find $outdir -name 'libv8_snapshot.a' | head -1`"" | |||
| libv8_snapshot=`find $outdir -name 'libv8_nosnapshot.a' | head -1`"" | |||
|
I'd like v8worker to continue to use snapshots, I see the error you're getting when using snapshots=on ... Let's try to find a fix |
|
Ok, i will try other build options for snapshots, we also having some troubles with slow worker creation. |
|
I think I figured it out, needs "-Dv8_use_external_startup_data=0". Testing a modified patch now, will land shortly |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest v8 uses own ArrayBufferAllocator per isolate, so i put it in worker_s structure. Also makefile uses 4.8-last_known_good_release version by default. I'm not sure about libv8_nosnapshot.a in build.sh, but it works and tests passes.