Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function "IAnimationGraphManagerHolder::NotifyAnimationGraph" to "SendAnimationEvent"? #47

Closed
max-su-2019 opened this issue Nov 14, 2020 · 2 comments

Comments

@max-su-2019
Copy link
Contributor

max-su-2019 commented Nov 14, 2020

I thinks the function name "NotifyAnimationGraph" is a little confused and may easily cause people don't know the meaning and features of this function.(At least it confuse me for a period )

Why not rename it as "SendAnimationEvent" which is a much familiar name that most of Bethesda game modder will know? It actually do the almost same thing with "SendAnimationEvent" papryus function and console command, right?

https://www.creationkit.com/index.php?title=SendAnimationEvent_-_Debug

@Ryan-rsm-McKenzie
Copy link
Owner

It's based off of the real name of the function

@max-su-2019
Copy link
Contributor Author

max-su-2019 commented Nov 15, 2020

Fine. So, Bethesda has name this function as "NotifyAnimationGraph", but when they call this function in papyrus scirpt and console command, they name it in a different name called "SendAnimationEvent". And that caused "SendAnimationEvent" has became the name we are familiar with instead of "NotifyAnimationGraph".

And I suppose in the future, there will be more developers likes me that will confused by the name of this function when they making project that depends on Commonlib.

I suggest that maybe you can add another member function to "Actor" class that name "SendAnimationEvent" which would allow developers to find out the function easier?

Or maybe at least you can add a line of comment under the "NotifyAnimationGraph" function, to remind other developers that this function is actually doing the things that “SendAnimationEvent' done?

alandtse referenced this issue in alandtse/CommonLibVR Jan 19, 2023
Add IngredientItem papyrus functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants