Error thrown on build with 0.1.3

[patlecat]

I got this persistent error on Windows8-64 with node.js v0.10.5 and ember-tools 0.1.3. And I just followed the simple example on your site here.:

C:\xxx\AppData\Roaming\npm\node_modules\ember-tools\src\commands\build.js:62
if (error) throw new Error(error);
^
Error: Error: Command failed: 'C:\xxx\AppData\Roaming\npm\node_modules\ember-tools\src\commands/../
../node_modules/browserbuild/bin/browserbuild' is not recognized as an internal or external command,
operable program or batch file.

at C:\xxx\AppData\Roaming\npm\node_modules\ember-tools\src\commands\build.js:62:22
at ChildProcess.exithandler (child_process.js:636:7)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:730:16)
at Socket.<anonymous> (child_process.js:943:11)
at Socket.EventEmitter.emit (events.js:95:17)
at Pipe.close (net.js:451:12)

[fivetanley]

Bah, Windows paths strikes again! Thanks, I'll try to find time to fix this one.

[patlecat]

I'd love to test it, I want to use ember for my new project. When do you think the fix will be ready?

[ryanflorence]

Can you try building with browserbuild directly? https://github.com/LearnBoost/browserbuild

[patlecat]

The build still doesn't work in the actual version 0.2 :(

C:...\my-app>ember build
created: js/templates.js
created: js/index.js
created: js/application.js
'C:...\AppData\Roaming\npm\node_modules\ember-tools\src\commands/../../node_modules/browserbuild/
bin/browserbuild' is not recognized as an internal or external command,
operable program or batch file.

C:...\AppData\Roaming\npm\node_modules\ember-tools\src\commands\build.js:66
if (error) throw new Error(error);
^
Error: Error: Command failed: 'C:...\AppData\Roaming\npm\node_modules\ember-tools\src\commands/../
../node_modules/browserbuild/bin/browserbuild' is not recognized as an internal or external command,
operable program or batch file.
at C:...\AppData\Roaming\npm\node_modules\ember-tools\src\commands\build.js:66:22
at ChildProcess.exithandler (child_process.js:641:7)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:735:16)
at Process.ChildProcess._handle.onexit (child_process.js:802:5)

[patlecat]

Can you try building with browserbuild directly?
How? I never used this.

[ryanflorence]

Just follow the directions on the README

[patlecat]

Give me the string to execute please. I don't know your lib nor that browserbuild. But you know them.

[ryanflorence]

I'm saying just follow the demo on browserbuild's project site and see if it works in windows or not.

[patlecat]

The result is the following code, which does not display "Hello world" in the browser though:

(function(){var global = this;function debug(){return debug};function require(p, parent){ var path = require.resolve(p) , mod = require.modules[path]; if (!mod) throw new Error('failed to require "' + p + '" from ' + parent); if (!mod.exports) { mod.exports = {}; mod.call(mod.exports, mod, mod.exports, require.relative(path), global); } return mod.exports;}require.modules = {};require.resolve = function(path){ var orig = path , reg = path + '.js' , index = path + '/index.js'; return require.modules[reg] && reg || require.modules[index] && index || orig;};require.register = function(path, fn){ require.modules[path] = fn;};require.relative = function(parent) { return function(p){ if ('debug' == p) return debug; if ('.' != p.charAt(0)) return require(p); var path = parent.split('/') , segs = p.split('/'); path.pop(); for (var i = 0; i < segs.length; i++) { var seg = segs[i]; if ('..' == seg) path.pop(); else if ('.' != seg) path.push(seg); } return require(path.join('/'), parent); };};require.register("lib\hithere.js", function(module, exports, require, global){
var b = require('./b')

module.exports = function () {
alert('hello ' + b());
}
});var exp = require('hithere');if ("undefined" != typeof module) module.exports = exp;else hithere = exp;
})();

[ryanflorence]

looks like it works then (just type hithere() in your terminal and it'll output the text).

So, something is up with the relative path, a fix might be to pull browserbuild in as a module and build with the module's api instead of as a binary (maybe?)

[patlecat]

No it doesn't output anything, neither in the console of the browser nor in the HTML code below (path is correct):

<script src="my-library.js"></script> <script> hithere(); </script>

[Steve-OH]

I'm having the same problem (Win 7 x64), and I can see where stuff is going wrong, although I don't fully understand the intent, so I don't know why it's going wrong.

1. Browserbuild does NOT work properly from a Windows cmd.exe command prompt (there's a command line parse error of some kind), but it does work from a bash prompt; I can build the example just fine.

2. However, build.js sends the following command line to the command processor:

C:\Users...\node_modules/browserbuild/bin/browserbuild ...

The problem is that the command processor is trying to execute that file directly, which it can't do because it's a JavaScript file with no file extension. Rather than

.../bin/browserbuild

shouldn't the command line be

node .../bin/browserbuild

In any case, I made that modification, but it still didn't work. The full path now looks like this:

node C:\Users...\node_modules\ember-tools\src\commands/../../node_modules/browserbuild/bin/browserbuild -m index -g App -b js/ find -L js -name '*.js' > js/application.js

But this fails (again, under bash) with the following error:

find: invalid predicate `-L'

Which doesn't really make any sense to me...

-Steve

[ryanflorence]

Thanks @Steve-OH

Yeah, I'm relying on find, a bash program to load in all the files. -L tells it to follow symlinks.

Looks like we may need to branch on OS and use some cmd.exe thing to find the files we hand to browserbuild. I'd love for this to work for windows users, but I'm going to leave it to windows users to provide the pull request. I have no grudge against the OS, I'd just rather spend time on other things.

(sounds so mean)

[thomasvm]

The above two changes make it the process run on my windows box. Instead of using find I'm using the glob node library to collect the js files and I explicitely use the node command to launch browserbuild. Warning: I have not tested this on a unix-box. If this would be good to go and you want me to create a separate pull request, just let me know.

[Steve-OH]

Those two changes seem to do the trick. Thanks.

-Steve

[Steve-OH]

Ryan,

I'd be happy to do a pull request, but the two changes really "belong" to Thomas.

Also, I don't have a way to test it on any *nix systems at the moment.

-Steve

[thomasvm]

Pull request created as #65

[ryanflorence]

Fixed by 2a93006 and e345e29.

Thanks @thomasvm :D

[ryanflorence]

this fix was released to npm, so enjoy windows users 👯

[patlecat]

Thanks guys, build now works on Windows :D

Just one small error in the Readme:
"open js/index.html" is incorrect because you place the index.html directly into my-app/ !

[Steve-OH]

You say "windows users" like it's a bad thing. ;-)

[thomasvm]

Glad to see I made some "Micro$oft Windoze" users happy :-)

[Inframatic]

I'm having the same problem but on a Mac :(