Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP 1193 Improvements #2

Closed
wants to merge 1 commit into from
Closed

EIP 1193 Improvements #2

wants to merge 1 commit into from

Conversation

@ryanio
Copy link
Owner

ryanio commented Mar 24, 2020

This PR targets some small improvements for EIP 1193:

  1. Allows params to also be type Object to support by-name variables (supported in both JSON-RPC and GraphQL specs).
  2. Adds language to encourage support of multiple transport methods beyond JSON-RPC.
  3. Improves introduction.
  4. Removes own error table in favor of error codes listed in EIP 1474.
  5. Removes sample class implementation.
    1. I'm not sure if it's useful to include, it was just my reference implementation while working on Mist.
  6. Some sentence and grammar improvements to improve clarity.

I posted this PR on my own fork because otherwise the the EIPs GitHub repo would auto-merge it before we could have any discussion.


The EIP has a few remaining discussion items before I would like to propose to move to "Last Call":

  1. Renaming send to request
    1. See ethereum#2319 (comment)
  2. Provider capability introspection
    1. See ethereum#2319 (comment)
@ryanio

This comment has been minimized.

Copy link
Owner Author

ryanio commented Mar 31, 2020

Some of these changes have been applied in ethereum#2577

@ryanio ryanio closed this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.