Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint checks to CI #100

Closed
ryanjulian opened this issue May 28, 2018 · 2 comments
Closed

Add lint checks to CI #100

ryanjulian opened this issue May 28, 2018 · 2 comments
Labels
quality Code quality enhancements

Comments

@ryanjulian
Copy link
Owner

Options:

  • pylint
  • autopep8
  • flake8
  • flake8-bugbear
  • pyflakes
  • pycodestyle
  • mypy
  • pytype

See:
https://github.com/PyCQA

Important rules (running list):

  • PEP8 import styling
@ryanjulian ryanjulian added the quality Code quality enhancements label May 28, 2018
@CatherineSue
Copy link
Collaborator

CatherineSue commented Jun 4, 2018

I find most python imports tools support alphabetical order only with import statements before from X import ... statements.

Flake8-import-order is the only tool I find that supports the alphabetical order we are using, which ignores 'from' or 'import' or 'as', like google. But flake8-import-order only prints the flake warnings instead of automatically reordering imports.

Other tools such as isort, autopep8 supports reorder, but they don't support the alphabetical order we are using. My guess is because PEP8 style only enforces groups without enforcing the order within the groups.

@ryanjulian
Copy link
Owner Author

See rlworkgroup/garage#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Code quality enhancements
Projects
None yet
Development

No branches or pull requests

2 participants