Address #364: catch errors per-section #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ryanluker#364, I accidentally produced a file that (apparently) has empty section filenames, as understood by the extension. This lead to an undefined property access (`split`) when trying to work with the file name; that exception propagated all the way up the rendering stack, resulting in _no_ coverage being displayed. With this change, if we encounter an error in `checkSection`, we just return `false` - if it's an erroneous section, it doesn't apply to the current file. (This is especially true if there is no `section.file` property!) This way, we still show coverage wherever we can.
ryanluker
reviewed
May 1, 2022
ryanluker
reviewed
May 1, 2022
ryanluker
reviewed
May 1, 2022
ryanluker
approved these changes
May 1, 2022
|
Thanks for the comments - glad I wasn't too far off base! |
ryanluker
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #364, I accidentally produced a file that (apparently) has empty
section filenames, as understood by the extension. This lead to an
undefined property access (
split) when trying to work with the filename; that exception propagated all the way up the rendering stack,
resulting in no coverage being displayed.
With this change, if we encounter an error in
checkSection, we just returnfalse- if it's an erroneous section, it doesn't apply to the currentfile. (This is especially true if there is no
section.fileproperty!)This way, we still show coverage wherever we can.