Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.2.1 #114

Merged
merged 3 commits into from
Jan 25, 2023
Merged

release 1.2.1 #114

merged 3 commits into from
Jan 25, 2023

Conversation

ryanmerolle
Copy link
Collaborator

Pull Request

Related Issue

New Behavior

...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Double Check

  • I have explained my PR according to the information in the comments
    or in a linked issue.
  • My PR targets the dev branch.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 25, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 17.62%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 1.67 ⭐ 1.67 👎
Method Length 90.00 🙂 103.50 🙂 13.50 👎
Working memory 3.50 ⭐ 6.83 🙂 3.33 👎
Quality 84.73% 67.11% 🙂 -17.62% 👎
Other metrics Before After Change
Lines 79 84 5
Changed files Quality Before Quality After Quality Change
netbox_acls/navigation.py 69.47% 🙂 60.53% 🙂 -8.94% 👎
netbox_acls/version.py 100.00% ⭐ 100.00% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ryanmerolle ryanmerolle merged commit 67da762 into release Jan 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants