Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed acl assignment form filtering #125

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fixed acl assignment form filtering #125

merged 2 commits into from
Feb 3, 2023

Conversation

abhi1693
Copy link
Member

Pull Request

Related Issue

New Behavior

...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Double Check

  • I have explained my PR according to the information in the comments
    or in a linked issue.
  • My PR targets the dev branch.

@abhi1693 abhi1693 added the enhancement New feature or request label Jan 28, 2023
@abhi1693 abhi1693 self-assigned this Jan 28, 2023
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 28, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.66%.

Quality metrics Before After Change
Complexity 12.55 🙂 15.26 🙂 2.71 👎
Method Length 122.78 😞 134.22 😞 11.44 👎
Working memory 10.53 😞 10.26 😞 -0.27 👍
Quality 50.75% 🙂 48.09% 😞 -2.66% 👎
Other metrics Before After Change
Lines 349 365 16
Changed files Quality Before Quality After Quality Change
netbox_acls/forms/models.py 50.75% 🙂 48.09% 😞 -2.66% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
netbox_acls/forms/models.py ACLInterfaceAssignmentForm.clean 15 🙂 282 ⛔ 15 😞 31.91% 😞 Try splitting into smaller methods. Extract out complex expressions
netbox_acls/forms/models.py AccessListForm.clean 21 😞 236 ⛔ 13 😞 32.23% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
netbox_acls/forms/models.py AccessListForm.__init__ 27 😞 194 😞 8 🙂 40.82% 😞 Refactor to reduce nesting. Try splitting into smaller methods
netbox_acls/forms/models.py ACLExtendedRuleForm.clean 15 🙂 121 😞 6 ⭐ 61.28% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ryanmerolle
Copy link
Collaborator

@abhi1693 Please rebase to dev and I will merge this in ASAP.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryanmerolle ryanmerolle merged commit 269354f into netbox-community:dev Feb 3, 2023
@ryanmerolle
Copy link
Collaborator

ty

@abhi1693 abhi1693 deleted the feat/form-filter branch February 3, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants