Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ryan- Thanks for this directive. We have a couple of issues, hopefully you can help with... #37

Open
beaubarbour opened this issue Feb 25, 2015 · 6 comments

Comments

@beaubarbour
Copy link

Problem #1 - We're using hm-tap on several elements but we were getting 'ghost' taps and problems with the tap being propagated despite our attempts to prevent propagation.

We tried to resolve this with by including hm-manager-options='{"enabled":true,"preventGhosts":true}' with the hm-tap elements but we didn't see any result from including the hm-manager-options.

To make it work, we had to put a timeout on all of our hmtap functions to prevent 'ghost' taps or double taps. The timeout solution seems to work on some devices but not on others.

Do you have any idea why the hm-manager-options isn't working for us?

Problem #2 - hm-swipe-left - Our app contains infinite vertical scrolling like twitter or instagram. We tried to include swipe/left/right functionality on elements inside the vertical scroll and it completely disable vertical scrolling. Again we tried to use hm-manager-options to enable default vertical scrolling (i.e. preventDefault:false,) by including hm-swipe, but again we didn't have a positive result, so we have had to disable all swipe/left/right functionality because it disables our default vertical scrolling.

Are we implementing the hm-manager-options wrong?

Should we be focusing on hm-recognizer-options?

Thanks again for this. Hope all is well.

@woutersf
Copy link

Problem #2 - hm-swipe-left - Our app contains infinite vertical scrolling like twitter or instagram. We tried to include swipe/left/right functionality on elements inside the vertical scroll and it completely disable vertical scrolling. Again we tried to use hm-manager-options to enable default vertical scrolling (i.e. preventDefault:false,) by including hm-swipe, but again we didn't have a positive result, so we have had to disable all swipe/left/right functionality because it disables our default vertical scrolling.

Same here, not sure what to do to fix this..

@davidtlee
Copy link

I'm getting the same problem with hm-pan.

@davidtlee
Copy link

Hey all, I got #2 to work by adding an hm-recognizer-options:
{"type":"pan","directions":"DIRECTION_HORIZONTAL"}

@woutersf
Copy link

For me it was
{"type":"swipe","directions":"DIRECTION_HORIZONTAL"}
That fixed it. Thanks!

@RyanMullins
Copy link
Owner

Can this be closed?

That first issue you have is a bigger problem with the Hammer library that I have a fix in for, but who knows if/when that will be integrated into their baseline.

@StMarcusDE
Copy link

Hi Ryan, you saying you have a fix for #1 - can you provide the solution? The Problem still seems to be there :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants