Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: custom element readonly prop always converted to readOnly #212

Closed
MarkChrisLevy opened this issue Mar 6, 2023 · 3 comments
Closed

bug: custom element readonly prop always converted to readOnly #212

MarkChrisLevy opened this issue Mar 6, 2023 · 3 comments

Comments

@MarkChrisLevy
Copy link
Contributor

Related to solidjs/solid#594 - basically you cannot have a custom element with readonly prop, as it is always converted to readOnly, which is required for input element, but readOnly is not part of HTMLElement spec, only HTMLInputElement.

https://playground.solidjs.com/anonymous/3385e30a-71ab-478f-8307-4752b1729eee

Aliasing readonly to readOnly should be made only for tag.
@ryansolid
Copy link
Owner

I hear you. Right now all aliases are global so would take some rework

@MarkChrisLevy
Copy link
Contributor Author

I can make a PR, including changes related to #211.

@MarkChrisLevy MarkChrisLevy mentioned this issue Mar 7, 2023
Merged
@MarkChrisLevy
Copy link
Contributor Author

Fixed with #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryansolid @MarkChrisLevy