Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning when returning within an ActiveRecord transaction in Rails 6.1 #208

Closed
cheeseweasel opened this issue Oct 15, 2020 · 0 comments · Fixed by #207
Closed

Comments

@cheeseweasel
Copy link
Contributor

We're getting the following deprecation warning from acts_as_votable in Rails 6.1:

DEPRECATION WARNING: Using `return`, `break` or `throw` to exit a transaction block is
deprecated without replacement. If the `throw` came from
`Timeout.timeout(duration)`, pass an exception class as a second
argument so it doesn't use `throw` to abort its block. This results
in the transaction being committed, but in the next release of Rails
it will rollback.
 (called from vote_by at /bundle/gems/acts_as_votable-0.12.1/lib/acts_as_votable/votable.rb:96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant