Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split functions into modules #13

Closed
NicoBurno opened this issue Sep 5, 2017 · 1 comment
Closed

Split functions into modules #13

NicoBurno opened this issue Sep 5, 2017 · 1 comment

Comments

@NicoBurno
Copy link

Most often, only some of the functions in the library are used...

Can we divide the eol.js into separate modules?
Then we can only use the functions we need here like this:

import split from 'eol/split';

Backward compatibility will be, if we leave the assembled version of the entry point.

@ryanve
Copy link
Owner

ryanve commented Sep 6, 2017

What would be the benefits? Would they warrant the excess tooling? It's only 41 lines and the methods share variables in the closure. Most usage of eol appears to be on the server. Also I think that there is a readability benefit to importing the whole library. I mean like eol.split seems more expressive than just split for example.

@ryanve ryanve closed this as completed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants