Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Emitter #12

Closed
jcemer opened this issue Dec 29, 2012 · 3 comments
Closed

Event Emitter #12

jcemer opened this issue Dec 29, 2012 · 3 comments

Comments

@jcemer
Copy link
Member

jcemer commented Dec 29, 2012

  1. This implementation dont allow only one handler to same event. https://github.com/Wolfy87/EventEmitter/blob/master/EventEmitter.js#L91
  2. The same implementation accepts multiple events.
    https://github.com/Wolfy87/EventEmitter/blob/master/EventEmitter.js#L181

What do you think about both?

@ricardobeat
Copy link
Member

I don't see the need to filter handlers when pushing them to the events array - you are allowed to add an event listener multiple times to a DOM element.

@jcemer
Copy link
Member Author

jcemer commented Dec 30, 2012

Yes, I think the same. And about 2?

@ricardobeat
Copy link
Member

We had decided to remove the multiple events implementation, no?

@jcemer jcemer closed this as completed Dec 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants