Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psychsyn code review #34

Open
franciscowilhelm opened this issue Apr 25, 2021 · 1 comment
Open

psychsyn code review #34

franciscowilhelm opened this issue Apr 25, 2021 · 1 comment
Labels
enhancement

Comments

@franciscowilhelm
Copy link
Collaborator

franciscowilhelm commented Apr 25, 2021 •
edited
Loading

  • psychsyn uses internal helpers, get_item_pairs and syn_for_one. What is the best way/place to put these helpers? Right now we have them at the end of psychsyn.R
  • potentially replace aperm() with t() as it produces identical results (verify) and is more well known, or else edit syn_for_one so that its output is shaped correctly.
  • write tests
@franciscowilhelm
Copy link
Collaborator Author

Changes on branch: psychsyn_update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franciscowilhelm