Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #62

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Minor fixes #62

merged 1 commit into from
Jul 29, 2018

Conversation

fireice-uk
Copy link
Member

@fireice-uk fireice-uk commented Jul 28, 2018 •
edited
Loading

  • ready

@psychocrypt psychocrypt self-requested a review July 28, 2018 19:05
@psychocrypt psychocrypt self-assigned this Jul 28, 2018
@psychocrypt psychocrypt added the bug Something isn't working label Jul 28, 2018
psychocrypt
psychocrypt reviewed Jul 28, 2018
View reviewed changes
src/cryptonote_core/cryptonote_tx_utils.cpp Outdated
@@ -136,7 +136,7 @@ bool construct_miner_tx(cryptonote::network_type nettype, size_t height, size_t
r = crypto::generate_key_derivation(dev_addr.address.m_view_public_key, txkey.sec, derivation);
CHECK_AND_ASSERT_MES(r, false, "while creating outs: failed to generate_key_derivation(" << dev_addr.address.m_view_public_key << ", " << txkey.sec << ")");

r = crypto::derive_public_key(derivation, 0, dev_addr.address.m_spend_public_key, out_eph_public_key);
r = crypto::derive_public_key(derivation, 1, dev_addr.address.m_spend_public_key, out_eph_public_key);
CHECK_AND_ASSERT_MES(r, false, "while creating outs: failed to derive_public_key(" << derivation << ", 0, " << dev_addr.address.m_spend_public_key << ")");

This comment was marked as abuse.

Sign in to view

@psychocrypt psychocrypt merged commit df6ec0a into ryo-currency:dev Jul 29, 2018
@psychocrypt psychocrypt added this to the 0.3.0.0 milestone Jul 31, 2018
@fireice-uk fireice-uk deleted the topic-minor-fixes branch August 24, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychocrypt psychocrypt psychocrypt left review comments

Assignees

@psychocrypt psychocrypt

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fireice-uk @psychocrypt