Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

Color Pulse Algorithm Modify #18

Closed
shinra358 opened this issue Apr 20, 2017 · 3 comments
Closed

Color Pulse Algorithm Modify #18

shinra358 opened this issue Apr 20, 2017 · 3 comments

Comments

@shinra358
Copy link

shinra358 commented Apr 20, 2017

I would like to ask that the algorithm for the lightbar color pulsing to be modified to coincide with the speed of the original lightbar pulse speed (orange charging light when ds4 is plugged without ds4windows). As it stands now, the pulse speed is too fast and the off light has lesser time than the on light. Each should be equal time. Not that big of a deal but I'm a perfectionist : P

This is for the [Pulse At] option.

@Ryochan7
Copy link
Owner

Ryochan7 commented Apr 21, 2017

It looks like that part of the code works based on number of gamepad polls instead of using a set time duration. Each direction of the pulse will take 100 polls to make a full transition; that behavior could be a big problem for people using a Bluetooth connection. This method will have to be changed to be time dependent instead.

Ryochan7 added a commit that referenced this issue Apr 22, 2017
Duration might change later. Related to issue #18.
@Ryochan7
Copy link
Owner

Regular pulse mode and pulse while charging works using set time intervals now. Regular pulse mode uses a 2 second interval per direction and pulse charging mode uses a 4 second interval per direction.

@shinra358
Copy link
Author

Excellent. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants