Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation via PyPi does not work #2

Closed
jfrtunikj-ae opened this issue May 16, 2023 · 3 comments
Closed

Installation via PyPi does not work #2

jfrtunikj-ae opened this issue May 16, 2023 · 3 comments

Comments

@jfrtunikj-ae
Copy link

Hi, thanks creating this very interesting repository. I was about to try out the package however when I install it via PyPi i.e. pip install pyfracgen and I try to import it I get this error:

Python 3.8.10 (default, Jun  4 2021, 15:09:15) 
[GCC 7.5.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyfracgen as pf
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jfrtunikj/python/lib/python3.8/site-packages/pyfracgen/__init__.py", line 1, in <module>
    from .buddhabrot import buddhabrot, compute_cvals
  File "/home/jfrtunikj/python/lib/python3.8/site-packages/pyfracgen/buddhabrot.py", line 7, in <module>
    from pyfracgen.mandelbrot import _mandelbrot
  File "/home/jfrtunikj/python/lib/python3.8/site-packages/pyfracgen/mandelbrot.py", line 12, in <module>
    xbound: tuple[float, float],
TypeError: 'type' object is not subscriptable

I use Python 3.8.10. Could you please assist what I am doing wrong? Thx!

@rytheranderson
Copy link
Owner

Ah, yeah I forgot to do from __future__ import annotations, type hints like tuple[float, float] don't work for 3.8.10. I will make the fix, in the meantime, this should work for 3.10.

@rytheranderson
Copy link
Owner

The latest version (0.0.10) should now work with 3.8.10, I set up a GHA to run mypy in 3.8, and that is working. Please try to reinstall from PyPi and let me know if it works.

@jfrtunikj-ae
Copy link
Author

Hi, thanks a lot for the fast fix. Now it works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants