Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate render and logic in TickerItem #30

Closed
ryuuart opened this issue May 7, 2023 · 0 comments · Fixed by #56
Closed

Separate render and logic in TickerItem #30

ryuuart opened this issue May 7, 2023 · 0 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request

Comments

@ryuuart
Copy link
Owner

ryuuart commented May 7, 2023

Right now, both are intermingled in TickerItem which really should be a common interface between both. What I propose is to create a RenderItem and LogicItem for the Item and extend off those base classes. This may change, but the overall goal is to be able to separate what should be logical or render operations.

For example, setting the style of a DOM Element, to me, counts as a render since it updates on the screen. A position that's tracked separately will then be used to update the style of the DOM element. This is a logical operation. The reason why we're being more explicit about this is because right now, updating position also clashes with trying to discern the logic of things.

We're basically trying to solve this problem.

@ryuuart ryuuart added the bug Something isn't working label May 7, 2023
@ryuuart ryuuart self-assigned this May 7, 2023
@ryuuart ryuuart added enhancement New feature or request and removed bug Something isn't working labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant