Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] lombok.config files aren't read in when compiling with sbt 1.4 #2645

Closed
rzwitserloot opened this issue Nov 13, 2020 · 7 comments
Closed

Comments

@rzwitserloot
Copy link
Collaborator

Describe the bug
Since about sbt 1.4, there's an incremental compilation thing happening with sbt which is causing the sourcefile field of javac's CompilationUnits to report a virtualized URI, which lombok cannot turn into a file path, thus causing lombok to just give up on trying to find the directory to start the chain of looking for lombok.config files.

To Reproduce
Compile 'Hello, World!' in a java file with sbt while you have a lombok.config file present; lombok will completely ignore that config file.

Additional context
The URI reported by sbt is something like vf://tmp/$%7BBASE%7D/src/main/java/example/Main.java

See also Pull Request 2643

@raphaelNguyen
Copy link

Thanks for fixing this up. Can I ask if there is a release scheduled that would contain this change some time soon?

@mkurz
Copy link
Contributor

mkurz commented Dec 5, 2020

@rzwitserloot Your fix for this issues is not complete: We ran into problems when using sbt subprojects. I provide a patch here: #2668 Please have a look (and merge 😉) before the next release, thanks!

@domdorn
Copy link

domdorn commented Dec 16, 2020

Any estimate when a new release will be published? This is currently blocking me from upgrading sbt 1.3.12 to 1.4.5. Thanks!

@rzwitserloot
Copy link
Collaborator Author

@domdorn are you looking for an edge release or lombok v1.18.18?

@mkurz
Copy link
Contributor

mkurz commented Dec 16, 2020

The edge release does not yet contain my fix for sbt subprojects (#2668). But it does work already for projects where Lombok is NOT used in a sub-project.

@mkurz
Copy link
Contributor

mkurz commented Dec 16, 2020

@rzwitserloot Would be nice if you could update the edge release to latest master 😉

@rzwitserloot
Copy link
Collaborator Author

Tonight probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants