Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hashtag recognition pattern for zwnj #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahangarha
Copy link

Regarding issue #30, this is my proposition.

Notice that there is ZWNJ (\u200c) between w and *.

@s
Copy link
Owner

s commented May 23, 2020

Hello @ahangarha, thank you for your report. Would you be willing to add tests for this PR? I'd like to merge it once we make sure it's not breaking existing tests as well as tests for the use case you mentioned. Thanks!

@ahangarha
Copy link
Author

Hello @ahangarha, thank you for your report. Would you be willing to add tests for this PR? I'd like to merge it once we make sure it's not breaking existing tests as well as tests for the use case you mentioned. Thanks!

I am not sure if I can write test. I would love to explore the code and see if I can find out how to do so, but it would take time. I can ask friends to look into the issue and code and see if they can do it. Should I?

@s
Copy link
Owner

s commented May 24, 2020

Hey @ahangarha, whichever way works for you is fine by me. I quickly checked out your changes. It seems to be breaking some of the tests. If you can add new changes to your PR to fix tests; that'd be great. Basically one of the ways that you can run the tests is as follows:

$ cd preprocessor/
$ python3 -m pytest

And then you should see something like this:

➜  preprocessor git:(master) python3 -m pytest
============================ test session starts =============================
platform darwin -- Python 3.7.6, pytest-5.3.5, py-1.8.1, pluggy-0.13.1
rootdir: /path/to/preprocessor
plugins: hypothesis-5.5.4, arraydiff-0.3, remotedata-0.3.2, openfiles-0.4.0, doctestplus-0.5.0, astropy-header-0.1.2
collected 25 items

tests/test_api.py ........                                             [ 32%]
tests/test_clean_numbers.py ..........                       [ 72%]
tests/test_utils.py .......                                            [100%]

============================= 25 passed in 0.08s =============================
➜  preprocessor git:(master)

@ahangarha
Copy link
Author

Soon I will look into it

@ahangarha
Copy link
Author

Oh! clearly I see a mistake in my regex.

I don't know why I made that mistake. I will fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants