Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parameterized arn generation; support elasticmq arn #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hzshlomi
Copy link

@hzshlomi hzshlomi commented Feb 11, 2019

Here's a quick fix allowing java users of the AWS SDK to get up and running quickly with elasticmq SQS queues registered on the SNS topics.
What I did is basically to transform ARNs starting with "arn:aws:sqs:elasticmq".
Everything i did is configurable, see (env var, configuration file property name):
ELASTICMQ_PREFIX, elasticmq.prefix
ELASTICMQ_ENDPOINT, elasticmq.endpoint
ELASTICMQ_ACCESS, elasticmq.access
ELASTICMQ_SECRET, elasticmq.secret

and also:
SNS_REGION, sns.region
SNS_ACCOUNT, sns.account

to allow control of the generated topic ARNs.
Pls let me know what needs to be done to merge this,
thanks for your work :)
Shlomi

@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #54 into master will decrease coverage by 1.92%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #54      +/-   ##
=========================================
- Coverage   40.52%   38.6%   -1.93%     
=========================================
  Files          22      22              
  Lines         422     443      +21     
  Branches       13      18       +5     
=========================================
  Hits          171     171              
- Misses        251     272      +21
Impacted Files Coverage Δ
.../main/scala/me/snov/sns/actor/SubscribeActor.scala 0% <0%> (ø) ⬆️
src/main/scala/me/snov/sns/Main.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15a2bb...5ca7ac3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants