Fix player.cpp crash when m_pActiveItem = null #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if this should be REGAMEDLL_FIXES, because I believe the original valve code has got this right (at least I don't get this crash with valve's mp.dll) |
|
it's my typo |
s1lentq
added a commit
that referenced
this pull request
Jan 6, 2016
Fix player.cpp crash when m_pActiveItem = null
|
Awesome work by the way! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to check if m_pActiveItem was != 0 after referencing it the line before.
(Fucked up last PR)