-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"image.jpg" is uploaded as a raw file and is not displayed in the browser. #3
Comments
With version 0.5.0, I decided to remove the default "metadata file" structure. the reason for this is that before adding the new blake3/bao hash tree format, the metadata file was required for verified streaming of a large file in chunks. As part of this change, raw file CIDs now also contain the encoded file size. So with the new powerful raw CIDs that support both verified streaming and include the file size, the only advantage of having an additional metadata file would be filename and media type metadata which is pretty small for a single file. Adding this as a new metadata format and CID would however come with significantly lower performance for fetching files, because it would need two requests on the p2p network for every file. This file can then for example be streamed in the browser using Setting a custom download filename is not possible yet, but can be added easily if you have a good use case for it. The new media file metadata format is meant to link multiple raw files that make up a single "media" item, for example different image formats and resolutions for the same image. |
Oh and thank you a lot for testing everything and your helpful feedback! |
hello redsolver, I'm very interested in the project and will help where I can. I have already tried to integrate dnslink in version 0.3.0, since they had already integrated hns, but unfortunately this no longer works in version 0.5.0 either. Being new to the Dart and Rust programming language myself, I'll have to wait for them to integrate it. Where I still have problems is to create a user, I don't understand yet. You should also expand "default_config.toml" with all valid entries, also commented out. To make it easier for other end users to find the right settings for their s5 node. |
Hello @resolver I despair right away. On all my 4 s5 nodes, I have the same problem when uploading. I have the test link Then I uploaded the "testlink.mp4" and tested the cid in the browser, and again it no longer works.
was pushed before the source code, making the file corrupt. I just saw that 4 additional lines were added to all uploaded files before the source code and 1 additional line was appended to the end of the file. What's going on there? Need help urgently as the problem is happening on all my 4 test s5 nodes. i need help from you |
Because the new default raw files no longer need filename metadata, the upload endpoint is simplified to just upload the entire request body as file. So instead of sending a form request, try sending the entire file as the body without any additional metadata. How are you uploading the file? |
single file:
or in uploads via my modified "nodejs-skynet" client via "scripts/upload.js" with the command: |
I think this is fixed |
Hello redsolver and s5-dev team,
I have extensively tested the latest version 0.5.0 from the master.
The installation in Windows10 and Ubuntu was a little bit complicated and there were 4 small warnings, but it installed in both systems and it works.
Will test it today also on linux 32bit.
The previous problems with "p2p" version 0.3.0 are gone. awesome
But there are other problems, such as:
If I want to call up the cids in the browser, the cid is downloaded and not displayed in the browser.
What am I doing wrong or is this a bug?
In the previous version 0.3.0 this worked great. In the new version 0.5.0 I can only display the individual files in the browser if I copy them to a directory before uploading and then upload the directory with the one file via "/s5/upload/directory".
I hope you can help.
The text was updated successfully, but these errors were encountered: