Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little love for tags in the entry editor #222

Closed
yellowled opened this issue Oct 30, 2014 · 27 comments
Closed

A little love for tags in the entry editor #222

yellowled opened this issue Oct 30, 2014 · 27 comments

Comments

@yellowled
Copy link
Member

See http://board.s9y.org/viewtopic.php?p=10440067#p10440067 etc. for details.

(Move to stable if needed; this should not be a release blocker for the RC.)

@bauigel
Copy link

bauigel commented Oct 30, 2014

Two things that could be done to make it a little bit more user friendly:

  1. move input-fied to top
  2. allow to hide #backend_freetag_list (user_admin.css still to available, isn't it?)

yellowled added a commit that referenced this issue Nov 13, 2014
- Includes new iconfont build with two new icons for entry state.
- JS to toggle entry status based on quick switch button.
- JS to toggle quick switch status based on entry status.
- JS to emit a notification that entry status has been updated.

References #222
yellowled added a commit that referenced this issue Nov 13, 2014
yellowled added a commit that referenced this issue Nov 13, 2014
yellowled added a commit that referenced this issue Nov 14, 2014
@yellowled
Copy link
Member Author

allow to hide #backend_freetag_list (user_admin.css still to available, isn't it?)

It's not even necessary; there is an option for that in the plugin's configuration.

yellowled added a commit that referenced this issue Nov 14, 2014
Needs a new version of freetag plugin, which is not committed (yet).

References #222
@yellowled
Copy link
Member Author

Related commit: additional_plugins/5f9ffb

yellowled added a commit that referenced this issue Nov 16, 2014
@yellowled
Copy link
Member Author

I consider this “done” as far as my ability to develop it is concerned.

If a plugin dev wants to give the possible solution mentioned in the forum a try, feel free to re-open this issue.

@ophian
Copy link
Member

ophian commented Nov 19, 2014

Just wanted to say thanks. This is much better now and will serve word artists! :)

@yellowled
Copy link
Member Author

You're welcome.

I'm still not sure this is “perfect”, but it's the best I can do now without having to make too many changes (which would require lengthy discussions).

@ophian
Copy link
Member

ophian commented Nov 20, 2014

Ups - I just compared our DEV netzblog with my local checkout and found this, which is for the (mega long) categories far from perfect at all...
cat-long
.........
cat-long-tags

@yellowled
Copy link
Member Author

I'm aware of that, but since it's only the fallback for no-overlay users (which I don't expect to be that many) … meh. And besides, it really is like @garvinhicking said in the forums – if you have really MANY categories (or tags, for that matter), there really is no good interface for this.

Have a look at how other blog backends handle this – Ghost doesn't even have categories, Wordpress doesn't list them (in the entry editor). Both only have autocompletion inputs for tags or categories. There's a reason for that.

@ophian
Copy link
Member

ophian commented Nov 20, 2014

I'm aware of that, but since it's only the fallback for no-overlay users

Hmm, I didn't think of being a non-overlay user. Is that set as default somehow, since my config there says:
popups-or-layers
?

@yellowled
Copy link
Member Author

No. Apparently, it's just that the category list is not hidden (like the tags) below the entry editors if overlays are used. Should be easy to fix, but I'm not sure if I'll get to that today.

@yellowled yellowled reopened this Nov 20, 2014
@yellowled
Copy link
Member Author

Sorry, that was wrong (because it was that way before) – both categories and tags are no longer hidden below the entry editors if overlays are used.

@yellowled
Copy link
Member Author

That should do the trick.

@ophian
Copy link
Member

ophian commented Nov 20, 2014

sorry - maybe I just see a bug where there isn't any, but now it looks like my local one
first-hit-new-entry-after-save-pp
Which is ok. I can tag right as before in 1.7, which I am happy with.

I would now expect the missing cat box being a button on top, pointing into an overlay for the categories.
But there is this
tag-button-instead-of categories
instead, pointing to tag overlay. Is that a mistake?

@yellowled
Copy link
Member Author

Is that a mistake?

If it is, it is a mistake in your local installation (wouldn't be the first) or cache-fu or something in your browser. It works exactly the way it is supposed to work in the dev blog for me now.

@ophian
Copy link
Member

ophian commented Nov 20, 2014

Well, apparently not - it were current snips from the DEVnetz Blog.
Ok really! - another hard reload cached away the tags in a box. So sadly I have to revert my happiness about its return to non-overlay. Couldn't we make this granular for tags? ;-)
(Hey! NO personal offence - I really appreciate your work!)

@yellowled
Copy link
Member Author

Couldn't we make this granular for tags?

I already suggested to make that config option more granular in the forums because I think people should be able to i.e. use overlays in the media db, but not for tags/categories if they so desire.

However, I don't think that's necessary for RC, and it definitely is not related to this issue.

@bauigel
Copy link

bauigel commented Nov 20, 2014

I already suggested to make that config option more granular in the forums
because I think people should be able to i.e. use overlays in the media db,
but not for tags/categories if they so desire.

However, I don't think that's necessary for RC, and it definitely is not
related to this issue.

​It is not possible to solve this through a simpletags-plugin-setting?​

@yellowled
Copy link
Member Author

​It is not possible to solve this through a simpletags-plugin-setting?​

I literally have no idea what you mean by that. So, probably not.

@ophian
Copy link
Member

ophian commented Nov 20, 2014

I literally have no idea what you mean by that. So, probably not.

An option in the freetags plugin, eg 'Use overlay: yes no' and then check this in ... whereever it is done.
Sounds like an easy solution for me.

@yellowled
Copy link
Member Author

I don't think it would be a good idea to have that in a plugin (which could be used with a completely different backend theoretically which doesn't even have an overlay).

But again, this is not related to this issue. Please open a seperate issue for this.

@ophian
Copy link
Member

ophian commented Nov 30, 2014

@yellowled I just updated my latest native test blog to the RC and installed the freetag plugin.
I now cannot find any place in a backend entry where I can see the tags already tagged to this entry.
The whole block <fieldset id="edit_entry_freetags" class="entryproperties_freetag mfp-hide"> is set to mfp-hide and the overlay only shows the tags which are available to set.
wher-are-tags
Do I miss something or is that too strict now?

@yellowled
Copy link
Member Author

#239

@yellowled
Copy link
Member Author

the overlay only shows the tags which are available to set

This, by the way, is not true. See the entry “Tag test” in the nbe backend – the input field in the overlay is populated with tags already assigned to that entry (and yes, the nbe blog is on rc-1).

@ophian
Copy link
Member

ophian commented Nov 30, 2014

It is, since I used the native lang, non-utf-8 test blog. :)
I just found the issue some minutes ago, which did not display the already tagged tags in the input field.

@yellowled
Copy link
Member Author

Well, in that case, it is not always true. :)

But it is also not an issue with the overlay or a design flaw. (Although I agree that this could maybe be better, see #239).

@ophian
Copy link
Member

ophian commented Nov 30, 2014

Hm I don't why it does not reference any more....
see fix and some remaining questions/issues commit s9y/additional_plugins@8a5bf1c

ophian added a commit to s9y/additional_plugins that referenced this issue Nov 30, 2014
@onli
Copy link
Member

onli commented Nov 30, 2014

Just as a not, I see neither a button nor a list in the backend as well. Seems like you are already on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants