Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Func<Arg, Retrun> hooks for on the fly behavior modification #26

Closed
GoogleCodeExporter opened this issue Sep 13, 2015 · 4 comments
Closed

Comments

@GoogleCodeExporter
Copy link

-Add Func<PageToCrawl, CrawlDecision> for ShouldCrawlPage
-Add Func<CrawledPage, CrawlDecision> for ShouldCrawlPageLinks
-Add Func<CrawledPage, CrawlDecision> for ShouldDownloadPageContent

Original issue reported on code.google.com by sjdir...@gmail.com on 7 Nov 2012 at 5:19

@GoogleCodeExporter
Copy link
Author

Pros: 
-Allows users to determine crawl behavior on the fly
-No classes or interfaces to implement and plugin

Cons:
-Not easy to test compound crawl behaviors
-Users must set these values on every instance (lots of copy and paste)
-Hard to group related or behaviors that are grouped together

Original comment by sjdir...@gmail.com on 31 Dec 2012 at 3:56

@GoogleCodeExporter
Copy link
Author

Issue 24 has been merged into this issue.

Original comment by sjdir...@gmail.com on 31 Dec 2012 at 3:56

@GoogleCodeExporter
Copy link
Author

Original comment by sjdir...@gmail.com on 31 Dec 2012 at 6:13

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Added ShouldCrawlPage(), ShouldCrawlPageLinks() and ShouldDownloadPageContent()

Original comment by sjdir...@gmail.com on 2 Jan 2013 at 6:59

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant