Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing -end-token.css in tests #64

Closed
remicollet opened this issue May 31, 2013 · 3 comments
Closed

Missing -end-token.css in tests #64

remicollet opened this issue May 31, 2013 · 3 comments

Comments

@remicollet
Copy link

Hi,

tests/Sabberworm/CSS/RuleSet/LenientParsingTest.php refers to tests/files/-end-token.css which doesn't exists.

@sabberworm
Copy link
Contributor

Keen observation. Indeed, I ignore the test files whose names start in a dash in my Git config because I normally use these to test bug reports. This must have slipped me somehow when I added these tests. I will fix them as soon as I get to my main work machine. I should also rename -fault-tolerance.css.

@remicollet
Copy link
Author

FYI, this library have been submitted for official Fedora repository
https://bugzilla.redhat.com/show_bug.cgi?id=969436

So I discover this issue running the test suite (which is always a best practice as part of the package build process).

@sabberworm
Copy link
Contributor

Thanks.

I just realised I can’t rename the files as they would get parsed by the generic test (ParserTest#testFiles), which will fail as these files SHOULD throw an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants