Include the chain ID and the Lockup model in the ID itself #909

Closed

PaulRBerg started this conversation in Ideas

PaulRBerg
Apr 25, 2024
Maintainer

Benefits: see Fjord's feedback below
Cons: increased gas cost

SCR-20240425-sgul

Replies: 1 comment 2 replies

smol-ninja
Apr 28, 2024
Maintainer

Why the chain ID?
If we include Lockup model in the ID, that means we will have two token IDs: 1. ERC-721 token ID and another string formatted token ID.

2 replies

PaulRBerg Apr 28, 2024
Maintainer Author

To make IDs unique across chains
That alone is a strong enough reason to discard this proposal

PaulRBerg Apr 28, 2024
Maintainer Author

Closing the discussion for now but we should monitor user feedback and explore potential solutions if this continues to be a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment