-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run fork tests on multiple chains #599
Comments
I was thinking to address this issue. Since forge does not provide helpers I am thinking to apply this methodology:
I am currently working on this locally, and it's going well. I will add the branch here once I push any commit. Reading the code will also make it easier to understand my methodology from above. @PaulRBerg tagging you to get notification |
I have to admit, this is taking much longer than expected. One factor that influences the speed of the process is that it takes forever to run fork tests against multiple assets and chains. I have successfully implemented this on this branch, but only for Linear. |
Wouldn't it burn RPC endpoints for fork tests? I am afraid we might be seeing more frequent stalled/failed tests due to rate limiting. And don't forget it already takes ~1 hr currently and with new fork tests, it may take ~6-7 hours or may be longer. Andrei, how long it takes to run all fork tests (i.e. 20 runs) on your machines? I may be wrong here but I think its overkill to run fork tests on all chains (after all they all are EVMs) 😅. |
I agree with Shub, it's overkill to run cross-chain forks tests. We're not a bridge so we are not interested in cross-chain communication. The Sablier protocol is siloed.
There are some important differences in opcode pricing and gas calculations, but we at Sablier have the privilege of being able to ignore them. |
Closing. Thank you for your efforts thus far @andreivladbrg. |
The fork tests are currently run against a single chain.
Ref: foundry-rs/book#872
The text was updated successfully, but these errors were encountered: