builld: upgrade to PRBMath V4 and update minimum pragma #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I ran the monotonicity test on |
Closed
test/fuzz/lockup/dynamic/streamed-amount-of/streamedAmountOf.t.sol
Outdated
Show resolved
Hide resolved
test/fuzz/lockup/dynamic/streamed-amount-of/streamedAmountOf.t.sol
Outdated
Show resolved
Hide resolved
test/fuzz/lockup/dynamic/streamed-amount-of/streamedAmountOf.t.sol
Outdated
Show resolved
Hide resolved
test/fuzz/lockup/dynamic/streamed-amount-of/streamedAmountOf.t.sol
Outdated
Show resolved
Hide resolved
It was indeed a critical issue. |
build: bump "forge-std" submodule build: bump "prb-contracts" submodule build: bump "prb-test" submodule
build: bump "prettier" Node.js dep chore: use "rm -rf" in "clean" script docs: add new keyword in "package.json"
test: document more invariants
test: add more context in comments test: disable protocol fee in "setUp" function test: fuzz segments in all "streamedAmountOf" fuzz tests test: rename fuzzing helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes four significant changes:
streamedAmountOffunction (Write fuzz test that showsstreamedAmountOfis a monotonic function #421)@andreivladbrg, you can start reviewing this,
though FYI I have also started working on #421, and I would like to include that test in this PR.Update: I just pushed a commit to address #421 by adding a test that verifies the monotonicity of the
streamedAmountOffunction. The PR is ready to be merged now, subject to your review, @andreivladbrg.